setParameters: Do argument checks in sync section and specify parellel steps #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-be
force-pushed
the
setparams-sync-part
branch
from
42fd551
to
dad40e5
Compare
adam-be
changed the title
taylor-b
reviewed
Sep 13, 2017
| <tr> | ||
| <td><dfn><code>hardware-encoder-error</code></dfn></td> | ||
| <td>The hardware encoder resources required for the requested | ||
| operation are not available.</td> |
There was a problem hiding this comment.
"... or the hardware encoder doesn't support the provided set of parameters"? Those could feasibly be two separate errors.
There was a problem hiding this comment.
Raised a separate issue for this question #1602
webrtc.html
Outdated
| <li>Resolve <var>p</var> with <code>undefined</code>.</li> | ||
| <li>Let <var>p</var> be a new promise.</li> | ||
| <li>In parallel, configure the media stack to use | ||
| <var>parameters</var> to transmit <var>sender</var>. |
There was a problem hiding this comment.
nit: It's not sender that's being transmitted, it's sender's track.
webrtc.html
Outdated
| created <code><a>RTCError</a></code> whose | ||
| <code>errorDetail</code> set to | ||
| "hardware-encoder-error".</li> | ||
| </ol> |
There was a problem hiding this comment.
Do we need a catchall "OperationError" if something non-hardware-related failed in the async steps?
There was a problem hiding this comment.
Let's add that. Hopefully it wouldn't be used much if we have a rather complete list of specific errors.
webrtc.html
Outdated
| <li>If an error occurred due to hardware resources not | ||
| being available, reject <var>p</var> with a newly | ||
| created <code><a>RTCError</a></code> whose | ||
| <code>errorDetail</code> set to |
|
Thanks for reviewing @taylor-b. New (and rebased) iteration coming up. |
adam-be
force-pushed
the
setparams-sync-part
branch
from
dad40e5
to
426672e
Compare
adam-be
force-pushed
the
setparams-sync-part
branch
from
426672e
to
9bc2856
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First stab, do not merge yet. We need to figure out what goes into the parallel steps.
fix #1520
Preview | Diff