Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readyState has no longer a muted value, use muted attribute instead #17

Merged
merged 2 commits into from
Dec 18, 2014

Conversation

dontcallmedom
Copy link
Member

@fluffy
Copy link
Contributor

fluffy commented Nov 5, 2014

LGTM


<p>In addition, a <code>MediaStreamTrack</code> has its
<code>readyState</code> set to <code>muted</code> on the remote peer if
<code>muted</code> set to <code>true</code> on the remote peer if
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it not be
muted attribute set to true on the remote peer if
?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed

@fluffy
Copy link
Contributor

fluffy commented Dec 4, 2014

LGTM

@stefhak
Copy link
Contributor

stefhak commented Dec 5, 2014

Could we (manually) merge this in now?

@fluffy
Copy link
Contributor

fluffy commented Dec 18, 2014

we can merge this once it is has the merge conflict fixed

@dontcallmedom dontcallmedom merged commit 482b557 into w3c:master Dec 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants