Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach simulcast offer sendEncodings to suitable (addTrack) transceiver. #2155

Merged
merged 3 commits into from
Apr 4, 2019
Merged

Attach simulcast offer sendEncodings to suitable (addTrack) transceiver. #2155

merged 3 commits into from
Apr 4, 2019

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Apr 1, 2019 •
edited by pr-preview bot
Loading

Fixes #2147.

Preview | Diff

@jan-ivar jan-ivar self-assigned this Apr 1, 2019
alvestrand
alvestrand reviewed Apr 2, 2019
View reviewed changes
webrtc.html Show resolved Hide resolved
alvestrand
alvestrand reviewed Apr 2, 2019
View reviewed changes
webrtc.html Show resolved Hide resolved
@alvestrand
Copy link
Contributor

I like where this is going.

henbos
henbos reviewed Apr 4, 2019
View reviewed changes
webrtc.html Outdated Show resolved Hide resolved
webrtc.html Show resolved Hide resolved
henbos
henbos approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@henbos henbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments

@henbos henbos added the Needs Test Needs a WPT test label Apr 4, 2019
@jan-ivar
Copy link
Member Author

jan-ivar commented Apr 4, 2019

Updated. Thanks for the feedback!

henbos
henbos reviewed Apr 4, 2019
View reviewed changes
webrtc.html
<var>transceiver</var>.<a>[[\Sender]]</a>.<a>[[\sendEncodings]]</a>
to <var>sendEncodings</var>, and set
<var>transceiver</var>.<a>[[\Sender]]</a>.<a>[[\LastReturnedParameters]]</a>
to <code>null</code>.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we allow modifying sendEncodings in subsequent offers for transceivers that already exist?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, suitable = unused. See #2147 (comment).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack!

@alvestrand alvestrand merged commit 42b2757 into w3c:master Apr 4, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Feb 17, 2020
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 17, 2020
@fippo @chromium-wpt-export-bot
webrtc wpt: add test for reusing a transceiver in simulcast
cb882a3 
adds a test case for
  w3c/webrtc-pc#2155

BUG=944821

Change-Id: Idee2e83cd6dbd217802698db46fe94b6ca0f0791
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 18, 2020
@fippo @chromium-wpt-export-bot
webrtc wpt: add test for reusing a transceiver in simulcast
b9aeb96 
adds a test case for
  w3c/webrtc-pc#2155

BUG=944821

Change-Id: Idee2e83cd6dbd217802698db46fe94b6ca0f0791
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 18, 2020
@fippo @chromium-wpt-export-bot
webrtc wpt: add test for reusing a transceiver in simulcast
aefa96d 
adds a test case for
  w3c/webrtc-pc#2155

BUG=944821

Change-Id: Idee2e83cd6dbd217802698db46fe94b6ca0f0791
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 18, 2020
@fippo @chromium-wpt-export-bot
webrtc wpt: add test for reusing a transceiver in simulcast
10de005 
adds a test case for
  w3c/webrtc-pc#2155

BUG=944821

Change-Id: Idee2e83cd6dbd217802698db46fe94b6ca0f0791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059972
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#742134}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 18, 2020
@fippo @chromium-wpt-export-bot
webrtc wpt: add test for reusing a transceiver in simulcast
7f0a51b 
adds a test case for
  w3c/webrtc-pc#2155

BUG=944821

Change-Id: Idee2e83cd6dbd217802698db46fe94b6ca0f0791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059972
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#742134}
@jan-ivar jan-ivar deleted the addtracksimulcast branch February 18, 2020 14:43
@jan-ivar jan-ivar removed the Needs Test Needs a WPT test label Feb 18, 2020
pull bot pushed a commit to FreddyZeng/chromium that referenced this pull request Feb 18, 2020
@fippo
webrtc wpt: add test for reusing a transceiver in simulcast
85cfd7b 
adds a test case for
  w3c/webrtc-pc#2155

BUG=944821

Change-Id: Idee2e83cd6dbd217802698db46fe94b6ca0f0791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059972
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#742134}
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Feb 21, 2020
@fippo @moz-wptsync-bot
Bug 1616124 [wpt PR 21841] - webrtc wpt: add test for reusing a trans…
f82eca3 
…ceiver in simulcast, a=testonly

Automatic update from web-platform-tests
webrtc wpt: add test for reusing a transceiver in simulcast

adds a test case for
  w3c/webrtc-pc#2155

BUG=944821

Change-Id: Idee2e83cd6dbd217802698db46fe94b6ca0f0791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059972
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#742134}

--

wpt-commits: 7f0a51b8417a3008d998403d3a3360ef9a4ca621
wpt-pr: 21841
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 21, 2020
@fippo @moz-wptsync-bot
Bug 1616124 [wpt PR 21841] - webrtc wpt: add test for reusing a trans…
3222fc6 
…ceiver in simulcast, a=testonly

Automatic update from web-platform-tests
webrtc wpt: add test for reusing a transceiver in simulcast

adds a test case for
  w3c/webrtc-pc#2155

BUG=944821

Change-Id: Idee2e83cd6dbd217802698db46fe94b6ca0f0791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059972
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#742134}

--

wpt-commits: 7f0a51b8417a3008d998403d3a3360ef9a4ca621
wpt-pr: 21841
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Feb 23, 2020
@marco-c
Bug 1616124 [wpt PR 21841] - webrtc wpt: add test for reusing a trans…
a9367cf 
…ceiver in simulcast, a=testonly

Automatic update from web-platform-tests
webrtc wpt: add test for reusing a transceiver in simulcast

adds a test case for
  w3c/webrtc-pc#2155

BUG=944821

Change-Id: Idee2e83cd6dbd217802698db46fe94b6ca0f0791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059972
Reviewed-by: Harald Alvestrand <htachromium.org>
Commit-Queue: Philipp Hancke <philipp.hanckegooglemail.com>
Cr-Commit-Position: refs/heads/master{#742134}

--

wpt-commits: 7f0a51b8417a3008d998403d3a3360ef9a4ca621
wpt-pr: 21841

UltraBlame original commit: ee113878703ea43bfce676e738d40b2f8f655ff9
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Feb 23, 2020
@marco-c
Bug 1616124 [wpt PR 21841] - webrtc wpt: add test for reusing a trans…
78ddbb6 
…ceiver in simulcast, a=testonly

Automatic update from web-platform-tests
webrtc wpt: add test for reusing a transceiver in simulcast

adds a test case for
  w3c/webrtc-pc#2155

BUG=944821

Change-Id: Idee2e83cd6dbd217802698db46fe94b6ca0f0791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059972
Reviewed-by: Harald Alvestrand <htachromium.org>
Commit-Queue: Philipp Hancke <philipp.hanckegooglemail.com>
Cr-Commit-Position: refs/heads/master{#742134}

--

wpt-commits: 7f0a51b8417a3008d998403d3a3360ef9a4ca621
wpt-pr: 21841

UltraBlame original commit: ee113878703ea43bfce676e738d40b2f8f655ff9
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Feb 23, 2020
@marco-c
Bug 1616124 [wpt PR 21841] - webrtc wpt: add test for reusing a trans…
97c59cc 
…ceiver in simulcast, a=testonly

Automatic update from web-platform-tests
webrtc wpt: add test for reusing a transceiver in simulcast

adds a test case for
  w3c/webrtc-pc#2155

BUG=944821

Change-Id: Idee2e83cd6dbd217802698db46fe94b6ca0f0791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059972
Reviewed-by: Harald Alvestrand <htachromium.org>
Commit-Queue: Philipp Hancke <philipp.hanckegooglemail.com>
Cr-Commit-Position: refs/heads/master{#742134}

--

wpt-commits: 7f0a51b8417a3008d998403d3a3360ef9a4ca621
wpt-pr: 21841

UltraBlame original commit: ee113878703ea43bfce676e738d40b2f8f655ff9
@fippo fippo mentioned this pull request Apr 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvestrand alvestrand alvestrand left review comments

@henbos henbos henbos approved these changes

@fippo fippo fippo approved these changes

@aboba aboba Awaiting requested review from aboba

@amithilbuch amithilbuch Awaiting requested review from amithilbuch

Assignees

@jan-ivar jan-ivar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

simulcast offer doesn't work with addTrack. An omission
4 participants
@jan-ivar @alvestrand @fippo @henbos