Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure icecandidate events happen after SLD success. #2203

Merged
merged 9 commits into from
Jul 18, 2019
Merged

Ensure icecandidate events happen after SLD success. #2203

merged 9 commits into from
Jul 18, 2019

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Jun 6, 2019 •
edited by pr-preview bot
Loading

Fixes #2199.

Preview | Diff

@jan-ivar jan-ivar self-assigned this Jun 6, 2019
alvestrand
alvestrand reviewed Jun 6, 2019
View reviewed changes
webrtc.html Outdated Show resolved Hide resolved
alvestrand
alvestrand reviewed Jun 6, 2019
View reviewed changes
webrtc.html Outdated Show resolved Hide resolved
alvestrand
alvestrand requested changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@alvestrand alvestrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. I think the basic idea is fine, but I don't like waiting.

@jan-ivar jan-ivar changed the title Ensure icecandidate events happen after SLD(offer). Ensure icecandidate events happen after SLD(offer) success. Jun 7, 2019
@jan-ivar jan-ivar changed the title Ensure icecandidate events happen after SLD(offer) success. Ensure icecandidate events happen after SLD success. Jun 7, 2019
@jan-ivar jan-ivar added the Needs Test Needs a WPT test label Jun 13, 2019
henbos
henbos reviewed Jul 11, 2019
View reviewed changes
webrtc.html Outdated Show resolved Hide resolved
jan-ivar
jan-ivar commented Jul 11, 2019
View reviewed changes
webrtc.html Outdated Show resolved Hide resolved
@jan-ivar
Copy link
Member Author

@henbos I now check in SLD() only. I broke out a "release early candidates" algorithm, which I think reads better. PTAL. My push blew away formatting again, which is #2226.

henbos
henbos reviewed Jul 12, 2019
View reviewed changes
webrtc.html Outdated Show resolved Hide resolved
webrtc.html Show resolved Hide resolved
@jan-ivar
Copy link
Member Author

Thanks @henbos for the good feedback! I think I got everything.

@jan-ivar jan-ivar merged commit 768044b into w3c:master Jul 18, 2019
@jan-ivar jan-ivar deleted the mustwait branch July 18, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvestrand alvestrand alvestrand requested changes

@henbos henbos henbos approved these changes

@aboba aboba Awaiting requested review from aboba

Assignees

@jan-ivar jan-ivar

Labels
Editors can integrate Needs Test Needs a WPT test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify/strengthen timing invariants of candidates not firing before SLD(offer)
4 participants
@jan-ivar @alvestrand @henbos @aboba