Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare final RFC references #2621

Merged
merged 7 commits into from
Jan 21, 2021
Merged

Prepare final RFC references #2621

merged 7 commits into from
Jan 21, 2021

Conversation

dontcallmedom
Copy link
Member

@dontcallmedom dontcallmedom commented Jan 18, 2021

Based on expected numbers in https://www.rfc-editor.org/auth48/C238

ReSpec will complain about the RFCs until specref picks the latest number (hopefully shortly after they get published).

This shouldn't be merged until the RFCs have been published


Preview | Diff

@fluffy
Copy link
Contributor

fluffy commented Jan 18, 2021

@dontcallmedom , do you want me to check that all the refs got changed to the correct RFC number or are you pretty sure you got that right ?

@dontcallmedom
Copy link
Member Author

@fluffy if you can give a look at the change, that would be much appreciated; I double checked but I wouldn't want to get this wrong :)

@dontcallmedom dontcallmedom marked this pull request as ready for review January 21, 2021 07:59
@aboba
Copy link
Contributor

aboba commented Jan 21, 2021

@dontcallmedom We noticed that a number of the references have been switched from normative to non-normative. Is this intentional?

@jan-ivar
Copy link
Member

For example, bundle is no longer listed under normative references

@dontcallmedom
Copy link
Member Author

I think you're mis-reading the diff - BUNDLE no longer appears as BUNDLE but as RFC8843 (which is still under the normative reference section )

@jan-ivar
Copy link
Member

Nevermind, it's listed as [RFC8843] instead now. The normative list is sorted, so the rename made it look like things were removed rather than changed.

@dontcallmedom
Copy link
Member Author

Note that we used to mistakenly have two names to refer to the same spec (SDP-SIMULCAST and MMUSIC-SIMULCAST), one listed in informative references and the other in normative references - they're recognized as a single spec listed in normative in this pull request

Copy link
Contributor

@henbos henbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question in 47 places

webrtc.html Show resolved Hide resolved
webrtc.html Show resolved Hide resolved
webrtc.html Show resolved Hide resolved
webrtc.html Show resolved Hide resolved
webrtc.html Show resolved Hide resolved
webrtc.html Show resolved Hide resolved
webrtc.html Show resolved Hide resolved
webrtc.html Show resolved Hide resolved
webrtc.html Show resolved Hide resolved
webrtc.html Show resolved Hide resolved
@dontcallmedom
Copy link
Member Author

@jan-ivar @aboba @henbos anything holding up merging this?

@dontcallmedom dontcallmedom merged commit 1f335b3 into master Jan 21, 2021
@fluffy
Copy link
Contributor

fluffy commented Jan 22, 2021

Thank you all for getting this sorted out so quickly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants