Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate rids in proposedSendEncodings. #2800

Merged
merged 4 commits into from
Dec 13, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions amendments.json
Original file line number Diff line number Diff line change
Expand Up @@ -346,5 +346,15 @@
"status": "candidate",
"id": 22
}
],
"apply-proposed-sendencodings": [
{
"description": "Remove duplicate rids in proposedSendEncodings.",
"pr": 2800,
"difftype": "modify",
"type": "correction",
"status": "candidate",
"id": 25
}
]
}
2 changes: 1 addition & 1 deletion base-rec.html
Original file line number Diff line number Diff line change
Expand Up @@ -2956,7 +2956,7 @@ <h5 id="x4-4-1-5-set-the-session-description"><bdi class="secno">4.4.1.5 </bdi>
each <a data-link-type="dfn" href="#dfn-media-description" class="internalDFN" id="ref-for-dfn-media-description-9">media description</a> in
<var>description</var>:
</p>
<ol>
<ol id="apply-proposed-sendencodings">
<li class="needs-tests">
<p>
If the <var>description</var> is of type
Expand Down
14 changes: 13 additions & 1 deletion webrtc.html
Original file line number Diff line number Diff line change
Expand Up @@ -2341,7 +2341,7 @@ <h4>
each [= media description =] in
<var>description</var>:
</p>
<ol>
<ol id="apply-proposed-sendencodings">
<li>
<p>
If the <var>description</var> is of type
Expand All @@ -2360,6 +2360,18 @@ <h4>
be an empty list.
</p>
</li>
<li>
<p>
For each encoding, <var>encoding</var>, in
<var>proposedSendEncodings</var> in reverse
order, if <var>encoding</var>'s
{{RTCRtpCodingParameters/rid}} matches that of
another encoding in
<var>proposedSendEncodings</var>, remove
<var>encoding</var>
from <var>proposedSendEncodings</var>.
</p>
</li>
<li>Let <var>supportedEncodings</var> be the
maximum number of encodings that the
implementation can support. If the length of
Expand Down