add RTCIceCandidatePair.responsesReceived to MTI stats #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fippo
changed the title
since it is typically paired with the MTI totalRoundTripTime https://www.w3.org/TR/webrtc-stats/#dom-rtcicecandidatepairstats-totalroundtriptime to calculate the average RTT and totalRoundTripTime is meaningless without it.
dontcallmedom
force-pushed
the
responsesreceived
branch
from
efd99bd
to
e81a749
Compare
|
while the change can be read as editorial under a certain lens, I think it doesn't pass the litmus test of "a conforming implementation would still conform after this change", so I've added an amendment to match |
jan-ivar
approved these changes
Mar 23, 2023
henbos
approved these changes
Mar 23, 2023
Editorial was perhaps overstating it. I meant it looked like a mistake. This is normative, so it's good we have the amendments. |
dontcallmedom
added a commit
to dontcallmedom/web-platform-tests
that referenced
this pull request
Nov 15, 2023
This was referenced Nov 15, 2023
dontcallmedom
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 16, 2023
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 22, 2023
…ceived to WebRTC mandatory stats, a=testonly Automatic update from web-platform-tests Add RTCIceCandidatePairStats.responsesReceived to WebRTC mandatory stats (#43172) Aligns with w3c/webrtc-pc#2832 -- wpt-commits: 037e5de33531d4be1354e11ddb87a025de50907a wpt-pr: 43172
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 22, 2023
…ceived to WebRTC mandatory stats, a=testonly Automatic update from web-platform-tests Add RTCIceCandidatePairStats.responsesReceived to WebRTC mandatory stats (#43172) Aligns with w3c/webrtc-pc#2832 -- wpt-commits: 037e5de33531d4be1354e11ddb87a025de50907a wpt-pr: 43172
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Nov 24, 2023
…ceived to WebRTC mandatory stats, a=testonly Automatic update from web-platform-tests Add RTCIceCandidatePairStats.responsesReceived to WebRTC mandatory stats (#43172) Aligns with w3c/webrtc-pc#2832 -- wpt-commits: 037e5de33531d4be1354e11ddb87a025de50907a wpt-pr: 43172
vinnydiehl
pushed a commit
to vinnydiehl/mozilla-unified
that referenced
this pull request
Nov 24, 2023
…ceived to WebRTC mandatory stats, a=testonly Automatic update from web-platform-tests Add RTCIceCandidatePairStats.responsesReceived to WebRTC mandatory stats (#43172) Aligns with w3c/webrtc-pc#2832 -- wpt-commits: 037e5de33531d4be1354e11ddb87a025de50907a wpt-pr: 43172
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 30, 2023
…ceived to WebRTC mandatory stats, a=testonly Automatic update from web-platform-tests Add RTCIceCandidatePairStats.responsesReceived to WebRTC mandatory stats (#43172) Aligns with w3c/webrtc-pc#2832 -- wpt-commits: 037e5de33531d4be1354e11ddb87a025de50907a wpt-pr: 43172 UltraBlame original commit: 5eed273c2eefaa58c38095a205d3c9ab2c2a7604
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 30, 2023
…ceived to WebRTC mandatory stats, a=testonly Automatic update from web-platform-tests Add RTCIceCandidatePairStats.responsesReceived to WebRTC mandatory stats (#43172) Aligns with w3c/webrtc-pc#2832 -- wpt-commits: 037e5de33531d4be1354e11ddb87a025de50907a wpt-pr: 43172 UltraBlame original commit: 5eed273c2eefaa58c38095a205d3c9ab2c2a7604
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 30, 2023
…ceived to WebRTC mandatory stats, a=testonly Automatic update from web-platform-tests Add RTCIceCandidatePairStats.responsesReceived to WebRTC mandatory stats (#43172) Aligns with w3c/webrtc-pc#2832 -- wpt-commits: 037e5de33531d4be1354e11ddb87a025de50907a wpt-pr: 43172 UltraBlame original commit: 5eed273c2eefaa58c38095a205d3c9ab2c2a7604
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since it is typically paired with the MTI totalRoundTripTime
https://www.w3.org/TR/webrtc-stats/#dom-rtcicecandidatepairstats-totalroundtriptime
to calculate the average RTT and totalRoundTripTime is meaningless without it.
editorial per this comment
Preview | Diff