Distinguish states from their attribute representation #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great improvement. The current mix with "connection.signalingState" in some sections and "RTCPeerConnection object's RTCPeerConnection signaling state" in others, is far from ideal. There might be other versions too. |
|
Re other fixes needed, I'm hoping to come up with a credible plan to transition us from WebIDL-oldschool to WebIDL contiguous for ReSpec in the upcoming few weeks; after that transition, I think I'll take a more thorough stab at distinguishing between the abstract model and the concrete API. |
Conflicts: webrtc.html
|
Merged master. One conflict in the new addIceCandidate() code that referred to signalling state. Will merge PR when Travis gives thumbs up. |
adam-be
added a commit
that referenced
this pull request
Dec 11, 2015
Distinguish states from their attribute representation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.