Adding expires attribute to generateCertificate. #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvestrand
added a commit
that referenced
this pull request
Dec 10, 2015
Adding expires attribute to generateCertificate.
|
Commenting on a closed CL: IDL-formally, I think it's a bit sad that the AlgorithmIdentifier is a typedef for "DOMString or object", since that means that we can't record in any IDL place that the "expires" field is added to it. No change needed. |
|
@alvestrand, I totally agree. I really wanted to do something more concrete. I'm not very happy with the WebCrypto API in many other respects either. |
aboba
added a commit
to w3c/ortc
that referenced
this pull request
Jan 4, 2016
…I (Section 4.11) Fix for Issue #303 Related to WebRTC 1.0 Issue w3c/webrtc-pc#386 WebRTC 1.0 PR relating to certificate expires attribute: w3c/webrtc-pc#429 Latest WebRTC 1.0 API editor's draft: http://w3c.github.io/webrtc-pc/#sec.cert-mgmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I said on the list, and as @SteelyGlint has noted, I'm not sure that this is the best approach, but it's what Firefox currently does.
Closes #386.