-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rtcpTransport description #595
Conversation
When you make two PRs that build on top of each other like this, please make a note of that in the description. It's otherwise confusing to see unrelated changes in the diff. |
75f0c36
to
b6177a6
Compare
The PR removes statements describing the effect of BUNDLE which were put in to respond to another issue. |
This seems to be the text Bernard's noting: "and will all send and receive RTCP over the same transport." Needs a rebase now that its parent is merged. |
Don't see the point here - it's not just a langauge cleanup, but it's not clear what it improves. |
b6177a6
to
8950379
Compare
With this patch, I want to clarify that the management of the rtcpTransport is the same in the case of BUNDLE that for rtcp-mux (it will be null), because BUNDLE mandates the usage of rtcp-mux. |
It loses the explicit note that with BUNDLE, all the RTCP for all the flows will go over the same transport channel. |
@mparis this is waiting for your response. |
8950379
to
135739c
Compare
BUNDLE mandates RTCP mux, so rtcpTransport will be null.
135739c
to
1485e62
Compare
Replaced by rebased PR #677 |
This PR depends on #594