Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rtcpTransport description #595

Closed
wants to merge 1 commit into from

Conversation

mparis
Copy link
Contributor

@mparis mparis commented Apr 25, 2016

This PR depends on #594

@alvestrand
Copy link
Contributor

When you make two PRs that build on top of each other like this, please make a note of that in the description. It's otherwise confusing to see unrelated changes in the diff.

@mparis mparis force-pushed the fix_rtcpTransport_description branch from 75f0c36 to b6177a6 Compare April 27, 2016 09:23
@aboba
Copy link
Contributor

aboba commented Apr 28, 2016

The PR removes statements describing the effect of BUNDLE which were put in to respond to another issue.

@alvestrand
Copy link
Contributor

This seems to be the text Bernard's noting: "and will all send and receive RTCP over the same transport."

Needs a rebase now that its parent is merged.

@alvestrand
Copy link
Contributor

Don't see the point here - it's not just a langauge cleanup, but it's not clear what it improves.
Unless a better reason is found, we'll close this.

@mparis
Copy link
Contributor Author

mparis commented Apr 29, 2016

With this patch, I want to clarify that the management of the rtcpTransport is the same in the case of BUNDLE that for rtcp-mux (it will be null), because BUNDLE mandates the usage of rtcp-mux.

@alvestrand
Copy link
Contributor

It loses the explicit note that with BUNDLE, all the RTCP for all the flows will go over the same transport channel.
(I think that's what @aboba intended to say).

@alvestrand
Copy link
Contributor

@mparis this is waiting for your response.

@mparis mparis force-pushed the fix_rtcpTransport_description branch from 8950379 to 135739c Compare May 22, 2016 18:56
BUNDLE mandates RTCP mux, so rtcpTransport will be null.
@mparis mparis force-pushed the fix_rtcpTransport_description branch from 135739c to 1485e62 Compare May 22, 2016 18:57
aboba added a commit that referenced this pull request May 26, 2016
@aboba
Copy link
Contributor

aboba commented May 26, 2016

Replaced by rebased PR #677

@aboba aboba closed this May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants