Specify how to handle invalid data channel IDs, or lack of IDs. #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue w3c#746. For an ID of 65535, createDataChannel will throw an exception. If it's determined that an ID is invalid for any other reason (such as shortage of negotiated SCTP streams), or if no more valid IDs are available when the user agent tries to pick an ID, the data channel will fire an "error" event and be closed. For now, I'm leaving the actual error as a "NetworkError", since I think we need to separately decide how error events on data channels work (see issue w3c#846).
pthatcherg
reviewed
Oct 6, 2016
| negotiated by the [[!RTCWEB-DATA]] implementations, or in the case where | ||
| the user agent generates an id according to [[!RTCWEB-DATA-PROTOCOL]], no | ||
| more IDs may be available. When the user agent determines that an | ||
| <code><a>RTCDataChannel</a></code>'s <a>underlying data transport</a> |
There was a problem hiding this comment.
What's an "underlying data transport"? Why not just say that an ID could not be allocated?
There was a problem hiding this comment.
What's an "underlying data transport"?
My assumption was that it refers to a DataChannel as defined by RTCWEB-DATA.
Why not just say that an ID could not be allocated?
I wanted to be as specific as possible (by providing examples), but also use terminology consistent with the rest of this section. I think "the underlying data transport cannot be created" accomplishes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #746.
For an ID of 65535, createDataChannel will throw an exception. If
it's determined that an ID is invalid for any other reason (such as
shortage of negotiated SCTP streams), or if no more valid IDs are
available when the user agent tries to pick an ID, the data channel will
fire an "error" event and be closed.
For now, I'm leaving the actual error as a "NetworkError", since I
think we need to separately decide how error events on data channels
work (see issue #846).