Add "packetsFailedDecryption", to count SRTP decryption failures. #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes w3c#249. This could be a useful statistic for diagnosing why calls are failing, in case an SRTP-related bug is introduced somewhere.
vr000m
approved these changes
Oct 20, 2017
webrtc-stats.html
Outdated
| <p> | ||
| The cumulative number of RTP packets that failed to be decrypted according | ||
| to the procedures in [[!RFC3711]]. These packets are not counted by | ||
| <code><a>packetsReceived</a></code> or <code><a>packetsDiscarded</a></code>. |
There was a problem hiding this comment.
This seems a bit odd, packetsReceived counter should go up when a packet is received and not after they have been decrypted. Aren't the packetsSent incremented when the frames are packetized and not when they are encrypted.
There was a problem hiding this comment.
Replace last sentence with "These packets are not counted by packetsDiscarded."
|
RFC3711 states:
So I was incorrect, this means that packetsReceived and packetsDiscarded do not increment when a packet fails decryption. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #249.
This could be a useful statistic for diagnosing why calls are failing,
in case an SRTP-related bug is introduced somewhere.