Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only expose RTCCodecStats objects currently in use #669

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Only expose RTCCodecStats objects currently in use #669

merged 2 commits into from
Sep 20, 2022

Conversation

henbos
Copy link
Collaborator

@henbos henbos commented Sep 7, 2022 •
edited by pr-preview bot
Loading

Fixes #662

Preview | Diff

@henbos henbos mentioned this pull request Sep 7, 2022
Closed
@henbos
Copy link
Collaborator Author

henbos commented Sep 13, 2022

Can we merge this?

vr000m
vr000m approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@vr000m vr000m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the property that the same {{RTCStats/id} is revived but want to confirm that reviving the {{RTCStats/id} is not a burden on the implementation?

If it is not a burden, I approve the merge.

@vr000m
Copy link
Contributor

vr000m commented Sep 20, 2022

cc: @jan-ivar WDYT about keeping the same ID?

@henbos
Copy link
Collaborator Author

henbos commented Sep 20, 2022

Codecs are created during negotiation so it is trivial to tie codec stats IDs to the monitored codec object, whether or not to expose the codec can be considered a filtering step. But if there are any concerns let's do a follow up

@henbos henbos merged commit 072f9dd into w3c:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vr000m vr000m vr000m approved these changes

@alvestrand alvestrand Awaiting requested review from alvestrand

Assignees
No one assigned
Labels
Editors can integrate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't expose so many RTCCodecStats!
2 participants
@henbos @vr000m