Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

algorithm names #21

Closed
dret opened this issue Oct 24, 2016 · 5 comments
Closed

algorithm names #21

dret opened this issue Oct 24, 2016 · 5 comments

Comments

@dret
Copy link
Member

dret commented Oct 24, 2016

is the list of algorithm names given in https://www.w3.org/TR/pubsub/#recognized-algorithm-names a closed and stable list? if not (and this should be looking forward a few years), maybe it would be a good idea to have a registry for them (with the four listed values as initial contents), so that new names can be added as they may get added by implementations and subsequently should be discoverable through the registry.

@aaronpk
Copy link
Member

aaronpk commented Oct 25, 2016

The entries in that list are from FIPS PUB 180-4 (as cited in that section) so maybe that can be the "registry"?

@dret
Copy link
Member Author

dret commented Oct 25, 2016

The entries in that list are from FIPS PUB 180-4 (as cited in that section) so maybe that can be the "registry"?

sounds reasonable. but then maybe be more clear about whether the list as provided by PubSub is a closed list and will not change, or that it is simply a snapshot and if FIPS PUB 180-4 changes, then so will the values allowed in PubSub.

julien51 added a commit that referenced this issue Nov 17, 2016
explicitly indicating that the list of algorithms can evolve. Fixes #21
@aaronpk
Copy link
Member

aaronpk commented Nov 19, 2016

@dret does that latest commit address the issue for you?

@dret
Copy link
Member Author

dret commented Dec 19, 2016

maybe change "The following algorithms are currently added as recognized algorithm names." to "The following algorithms are the initially registered algorithm names, based on the current content of the referenced registry." ("currently added" sounds a bit odd to me), but that's just a nit.
generally speaking, i think it's good enough as it makes clear that the list of algorithm names is evolving, and it identifies the registry to use for lookup.

@aaronpk
Copy link
Member

aaronpk commented Dec 19, 2016

Thanks. I agree that sounds a little awkward, so I rephrased it slightly like you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants