Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the syntax of Region headers #231

Closed
zcorpan opened this issue Oct 30, 2015 · 4 comments
Closed

Change the syntax of Region headers #231

zcorpan opened this issue Oct 30, 2015 · 4 comments
Assignees

Comments

@zcorpan
Copy link
Member

zcorpan commented Oct 30, 2015

See https://www.w3.org/Bugs/Public/show_bug.cgi?id=18657

It is suggested to change the syntax here to use REGION blocks before the cues (consistent with STYLE), instead of headers. I suppose this would also be an opportunity to change from = to : so that would be consistent with cue settings.

If we use a block it would be possible to allow linebreaks between settings here, if people think that would be nice to be able to do. e.g.

WEBVTT

REGION
id:fred
width:40%
lines:3
regionanchor:0%,100%
viewportanchor:10%,90%
scroll:up

REGION
id:bill width:40% lines:3 regionanchor:100%,100% viewportanchor:90%,90% scroll:up

...

Apple has shipped support for regions, so need to check with them if this change is OK. @dwsinger ?

@silviapfeiffer
Copy link
Member

Eric Carlson's statement at the recent FOMS was that if we want to change it, now is the time.

@eric-carlson
Copy link

I support this, making region consistent with style is a great idea.

@zcorpan
Copy link
Member Author

zcorpan commented Nov 5, 2015

Need to fix #222 first to do this in a sane way. (Depends on: #246)

zcorpan added a commit that referenced this issue Dec 1, 2015
This makes region definitions more consistent with both STYLE
blocks as well as cue settings.
@zcorpan zcorpan self-assigned this Dec 1, 2015
zcorpan added a commit that referenced this issue Dec 4, 2015
This makes region definitions more consistent with both STYLE
blocks as well as cue settings.
@zcorpan zcorpan closed this as completed in 13e4a16 Jan 5, 2016
@silviapfeiffer
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants