Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing EOF check in 'WebVTT parser algorithm' #327

Closed
BenjaminSchaaf opened this issue Feb 9, 2017 · 2 comments
Closed

Missing EOF check in 'WebVTT parser algorithm' #327

BenjaminSchaaf opened this issue Feb 9, 2017 · 2 comments
Assignees

Comments

@BenjaminSchaaf
Copy link
Contributor

In 5.1. 'WebVTT parser algorithm', Step 9 may advance the position possibly leading to an EOF while Step 10 assumes no EOF has been reached.

If at Step 9 the character indicated by position is a LF followed by the EOF a direct translation of the algorithm may crash.

@dwsinger
Copy link

dwsinger commented Feb 9, 2017 via email

@BenjaminSchaaf
Copy link
Contributor Author

That works for me

zcorpan added a commit that referenced this issue Feb 9, 2017
@zcorpan zcorpan self-assigned this Feb 9, 2017
zcorpan added a commit that referenced this issue Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants