Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use [Exposed] consistently #358

Closed
zcorpan opened this issue Aug 22, 2017 · 3 comments
Closed

Use [Exposed] consistently #358

zcorpan opened this issue Aug 22, 2017 · 3 comments

Comments

@zcorpan
Copy link
Member

zcorpan commented Aug 22, 2017

I accidentally pushed 30dab2c directly to gh-pages when I meant to create a new remote branch. :-(

The change has no normative impact, but is necessary for whatwg/webidl#365

Filing this here for better visibility and FYI, and in case somebody likes to review the change. cc @annevk @tobie

Will keep this open to track updating interfaces.html in web-platform-tests.

@annevk
Copy link
Member

annevk commented Aug 22, 2017

r+ for index.bs changes.

@silviapfeiffer
Copy link
Member

Fine by me. No worries about this change.

Since this is something that can happen quite easily accidentally, how about using GitHub's safety features? In the settings for this repo, you could change the gh-pages and master branches to protected branches to require reviews before landing. Just a thought.

@zcorpan
Copy link
Member Author

zcorpan commented Aug 23, 2017

@silviapfeiffer thanks, I've now ticked some checkboxes in settings.

zcorpan added a commit to web-platform-tests/wpt that referenced this issue Aug 23, 2017
zcorpan added a commit to web-platform-tests/wpt that referenced this issue Aug 23, 2017
rachelandrew pushed a commit to rachelandrew/web-platform-tests that referenced this issue Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants