Default font size 5vh leads to very large cues for vertical videos
#522
Comments
|
|
webkit-commit-queue
pushed a commit
to jernoble/WebKit
that referenced
this issue
Dec 5, 2023
…rtrait view https://bugs.webkit.org/show_bug.cgi?id=265817 rdar://118030141 Reviewed by Simon Fraser. When a landscape video is presented in portrait mode (with large letterboxes), this causes the font size of the associated text tracks to be absurdly large. Filed a spec issue on WebVTT (w3c/webvtt#522) to change the default font size be `5vmin` rather than `5vh`, but proceeding with changing WebKit's default font size to be `5cqh` in the meantime. * Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css: (::-webkit-media-text-track-region): Canonical link: https://commits.webkit.org/271536@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The spec currently says:
This value of
5vhleads to unreasonably large cues for vertical videos. See example here: http://jernoble.github.io/samples/bin/WebVTT/resize-aspect.htmlInstead, the spec could use
5vmin(or actually, move away from redefining viewports entirely and use5cqmininstead). The example above allows you to switch between5vhand5vminto see the difference in behavior.The text was updated successfully, but these errors were encountered: