Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "User agents that do not support CSS" conformance class. #389

Merged
merged 10 commits into from Jan 10, 2018

Conversation

silviapfeiffer
Copy link
Member

@silviapfeiffer silviapfeiffer commented Oct 1, 2017

This actually introduces a definition for "WebVTT cue setting" and
clarifies how they provide information to position and align the cue
box and cue text.

Closes #361

Addresses issue w3c#361
Adds the new conformance class and clarifies a couple of places
where "user agent" was used such that there may have been confusion
as to a possibility for reference to different types of user agents.
@silviapfeiffer silviapfeiffer added this to the WD-wide-review milestone Oct 15, 2017
@silviapfeiffer
Copy link
Member Author

ping @TairT for review

@andreastai
Copy link

From my side a merge of this PR needs to wait for a solution of #365.

See also #395 (comment) and #361 (comment).

@silviapfeiffer
Copy link
Member Author

This should only address #361 and no other issue. Are you ok that this patch addresses #361 ?

@silviapfeiffer
Copy link
Member Author

@dwsinger I need a reviewer on this patch

Copy link

@dwsinger dwsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in english requires takes a gerund, so "requires to apply" should probably be "requires applying" except I am hesitant to alter definition text...

@silviapfeiffer
Copy link
Member Author

I'm going to replace /requires to/ with /says to/.

I'm proposing to introduce 3 conformance classes as per #410 - patch upcoming.

Copy link

@andreastai andreastai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented in #361 all UA conformance classes need to support color. Either this is not the case through the latest changes (see comments) or this not made clear enough.

index.bs Outdated
<dd><p>All processing requirements in this specification apply, except those in
[[#css-extensions]]. The user agent must instead implement equivalent visual rendering to what a
CSS based renderer produces according to [[#rendering]]. [[#applying-css-properties]] lists the
default styling properties in CSS speak that will also define the default styling in such user

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may mistankingly imply that all CSS extension features need to be supported. But this is not what is intended?

index.bs Outdated
relate to stylesheets and CSS, and all of [[#rendering]] and [[#css-extensions]]. The user agent
must instead only render the text inside <a>WebVTT cue text</a> in an appropriate manner. Any other
styling and positioning instructions are optional.</p> </dd>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I misunderstood something, we seem to go in circles.

When it says for "User agents that do not support CSS"

The user agent must instead only render the text inside WebVTT cue text in an appropriate manner. Any other styling and positioning instructions are optional.

...it seems again also exlcude the required support for color. It even goes further and makes positioning (which is not defined by CSS extensions but by Cue settings) optional.

@dwsinger
Copy link

Obviously not clear enough. Non-CSS UAs are not required to parse and implement STYLE blocks, i.e. new CSS. They must nonetheless respect markup in cues, and the layout model (both of which are CSS-derived).

@silviapfeiffer
Copy link
Member Author

silviapfeiffer commented Dec 12, 2017

Ah ok, misunderstanding from my side. I thought that no CSS means none of the CSS functionality.

@dwsinger
Copy link

I think supporting pre-defined colors is unproblematic, and what we agreed with Andreas...

@silviapfeiffer
Copy link
Member Author

It's ok, I only just connected the dots how that referred back to the colors. I'll propose a change next week.

@andreastai
Copy link

@silviapfeiffer Thanks!

@silviapfeiffer
Copy link
Member Author

I've explicitly stated now that the color classes must be supported by every conformance class, with or without CSS. @TairT could you re-review? Thanks!

@dwsinger
Copy link

dwsinger commented Jan 5, 2018 via email

Copy link

@andreastai andreastai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @silviapfeiffer! It was a long way but finally we got there. Thanks to @silviapfeiffer and @dwsinger for your patience.

@silviapfeiffer
Copy link
Member Author

Awesome, thanks!

@silviapfeiffer silviapfeiffer merged commit f3ca636 into w3c:gh-pages Jan 10, 2018
@silviapfeiffer silviapfeiffer deleted the conformance-class-css branch January 10, 2018 19:50
@dwsinger
Copy link

thank you both for your patience and persistence also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants