Cue setting clarifications #420
Conversation
index.bs
Outdated
| first line of the cue. Positive line numbers count from the start of the video viewport (the first | ||
| line is numbered 0), negative line numbers from the end of the viewport (the last line is numbered | ||
| −1).</p> | ||
| percentage of the relevant writing-mode dependent video dimension or as a line number. Line numbers |
There was a problem hiding this comment.
The video dimension not the video viewport dimension?
There was a problem hiding this comment.
The "video viewport" is the rendering area of the video, which is the only area that we're able to render anything onto, so for all intents and purposes it's really just a description of the video dimensions.
There was a problem hiding this comment.
@nigelmegitt I can use "video viewport dimension" if you think it makes more sense.
There was a problem hiding this comment.
@silviapfeiffer that would seem more consistent, modulo the comments on the related issue, that viewport units are not video viewport units.
There was a problem hiding this comment.
@nigelmegitt for now, I've made sure to use "video viewport" everywhere to clarify for this issue. I'll address the definition of the term "video viewport" in #375 .
There was a problem hiding this comment.
OK, thanks @silviapfeiffer
|
Is there an issue reference for this pull request please? |
|
Hmm, I don't know where this was discussed now and forgot to link it in the commit. I think it might have been #375 but only addresses a part of it. |
This is now either "video viewport" or "region viewport".
No description provided.