Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cue setting clarifications #420

Merged
merged 10 commits into from Feb 25, 2018

Conversation

Projects
None yet
4 participants
@silviapfeiffer
Copy link
Member

commented Dec 8, 2017

No description provided.

index.bs Outdated
first line of the cue. Positive line numbers count from the start of the video viewport (the first
line is numbered 0), negative line numbers from the end of the viewport (the last line is numbered
&#x2212;1).</p>
percentage of the relevant writing-mode dependent video dimension or as a line number. Line numbers

This comment has been minimized.

Copy link
@nigelmegitt

nigelmegitt Dec 13, 2017

Contributor

The video dimension not the video viewport dimension?

This comment has been minimized.

Copy link
@silviapfeiffer

silviapfeiffer Dec 21, 2017

Author Member

The "video viewport" is the rendering area of the video, which is the only area that we're able to render anything onto, so for all intents and purposes it's really just a description of the video dimensions.

This comment has been minimized.

Copy link
@silviapfeiffer

silviapfeiffer Jan 31, 2018

Author Member

@nigelmegitt I can use "video viewport dimension" if you think it makes more sense.

This comment has been minimized.

Copy link
@nigelmegitt

nigelmegitt Feb 14, 2018

Contributor

@silviapfeiffer that would seem more consistent, modulo the comments on the related issue, that viewport units are not video viewport units.

This comment has been minimized.

Copy link
@silviapfeiffer

silviapfeiffer Feb 25, 2018

Author Member

@nigelmegitt for now, I've made sure to use "video viewport" everywhere to clarify for this issue. I'll address the definition of the term "video viewport" in #375 .

This comment has been minimized.

Copy link
@nigelmegitt
@nigelmegitt

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2017

Is there an issue reference for this pull request please?

@silviapfeiffer

This comment has been minimized.

Copy link
Member Author

commented Dec 21, 2017

Hmm, I don't know where this was discussed now and forgot to link it in the commit. I think it might have been #375 but only addresses a part of it.

@dwsinger
Copy link

left a comment

LGTM

silviapfeiffer added some commits Feb 25, 2018

Fix up the use of "viewport" everywhere
This is now either "video viewport" or "region viewport".

@silviapfeiffer silviapfeiffer merged commit 8ea7f22 into w3c:gh-pages Feb 25, 2018

1 check passed

ipr PR deemed acceptable.
Details

@silviapfeiffer silviapfeiffer deleted the silviapfeiffer:cue-setting-clarifications branch Feb 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.