Region lines cannot be negative now that they are unsigned long. #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please merge this change. |
|
@dwsinger I need a review |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 1, 2018
updated idl file and VTTScanner updated test cases and expected results https://w3c.github.io/webvtt/#dom-vttregion-lines w3c/webvtt#423 Bug: 755487 Change-Id: Ifd1ef26ede8cbc4f6bfe817aae9bce1191c18d24
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 1, 2018
updated idl file and VTTScanner updated test cases and expected results https://w3c.github.io/webvtt/#dom-vttregion-lines w3c/webvtt#423 Bug: 755487 Change-Id: Ifd1ef26ede8cbc4f6bfe817aae9bce1191c18d24 Reviewed-on: https://chromium-review.googlesource.com/826666 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#533586}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 1, 2018
updated idl file and VTTScanner updated test cases and expected results https://w3c.github.io/webvtt/#dom-vttregion-lines w3c/webvtt#423 Bug: 755487 Change-Id: Ifd1ef26ede8cbc4f6bfe817aae9bce1191c18d24 Reviewed-on: https://chromium-review.googlesource.com/826666 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#533586}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #414