Make VTTRegion lines be a long. #461
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 24, 2019
|
Once this lands, #460 can be updated with it and web-platform-tests/wpt#17400 can be updated to remove the now unnecessary lines-long.html test. |
|
Was the HTML auto-created using bikeshed? |
|
It was, I just cherry-picked only the relevant changes. I can make a separate update-bikeshed PR and then rebase that against it. |
gkatsev
added a commit
to gkatsev/webvtt
that referenced
this pull request
Jun 26, 2019
silviapfeiffer
approved these changes
Jul 18, 2019
This was referenced Mar 2, 2021
Because WebIDL doesn't include an unsigned int, the VTTRegion interface specifically calls out that negative numbers should cause an IndexSizeError, and browser implementations are in the unsigned int, switch over to using a regular long value. Using a long gives us the correct range and with the definition that specifies throwing means that negative values are not allowed. This was discussed in the [20 June, 2019 TTWG call](https://www.w3.org/2019/06/20-tt-minutes.html#x02) Fixes w3c#457.
gkatsev
force-pushed
the
use-regular-long
branch
from
c5afe50
to
28a0417
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because WebIDL doesn't include an unsigned int, the VTTRegion interface
specifically calls out that negative numbers should cause an
IndexSizeError, and browser implementations are in the unsigned int,
switch over to using a regular long value.
Using a long gives us the correct range and with the definition that
specifies throwing means that negative values are not allowed.
This was discussed in the 20 June, 2019 TTWG call
Fixes #457.
Preview | Diff
Preview | Diff