Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft telemetry section #728

Merged
merged 4 commits into from
Apr 7, 2022
Merged

Draft telemetry section #728

merged 4 commits into from
Apr 7, 2022

Conversation

mlagally
Copy link
Contributor

@mlagally mlagally commented Apr 1, 2022

Closes 661


Preview | Diff

Copy link
Contributor

@egekorkan egekorkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request change is mostly due to my first comment about bearer

index.html Outdated
<p>
Telemetry is the monitoring of remove devices, which implies automatic transmission to, and processing
of measurements and other data on a <a>Consumer</a>.
Data may be transported over various bearers, both wireless and wired.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bearer is not defined in the terminology

Copy link
Contributor Author

@mlagally mlagally Apr 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@egekorkan We could use "communication channels" as an alternative wording.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that would be better :)

index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
user-operated remote controller as depicted in <a href="#smart-home-device"></a>. A remote
controller can access an electronic appliance
A common deployment pattern is a local device controlled by a
user-operated remote controller as depicted in <a href="#smart-home-device"></a>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about industry-based controllers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be another example of Device Controllers.
Note that this MR focuses on the Telemetry description and just changes the numbering of the first sentence of the "Device Controllers" section.

Please create a MR to add "industrial controllers" to that section.

<h3>Telemetry</h3>
<p>
Telemetry is the monitoring of remove devices, which implies automatic transmission to, and processing
of measurements and other data on a <a>Consumer</a>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consumer: Since the definition of WoT entities (Thing/Intermediary/Consumer) is given later in Chapter 6, so what about to use a generic term (e.g. "data collector") rather than a WoT-specific term here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k-toumura If we would use "data collector" we would have to define it in the terminology.
A "data collector" sounds like it is only storing the data. Typically the consumer does processing, applies rules, ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use "data consumer" if it makes the text clearer, what do you think?

Copy link

@chachamimm chachamimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If comments of other members is supported, I will approve.

@mlagally mlagally merged commit 2ef10d6 into main Apr 7, 2022
@mlagally mlagally deleted the telemetry branch August 29, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to have a description of a telemetry system topology in chapter 6
6 participants