Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix section structure error (6. Cross-domain Collaboration, 7. System Integration) #774

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

k-toumura
Copy link
Contributor

@k-toumura k-toumura commented May 25, 2022

(related issue/PR: #628, #771)
I didn't notice in on the Arch call in May 24th, some structure of section seems broken.
There is extra </section> tag on after "5.9 Virtual Things":

wot-architecture/index.html

Lines 1568 to 1571 in 02b9aea

</p>
</section>
</section>

This extra tag accidentally makes the subsequent "Cross-domain Collaboration" and "System Integration" subsection independent from the Section 5 "Common Deployment Patterns".

This PR remove the extra section tag, and also remove introduction text for "Cross-domain Collaboration" and "System Integration" (and also fix section ID). The resulting section structure is as follows:

  ...
5. Common Deployment Patterns
5.1 Telemetry
  ...
5.9 Virtual Things
5.10 Cross-domain Collaboration
5.11 System Integration
6. Abstract WoT System Architecture
  ...

(if the original section structure is intentional, please close this PR)


Preview | Diff

@@ -380,13 +380,6 @@ <h1>Introduction</h1>
<li>a set of common deployment patterns in
<a href="#sec-common-deployment-patterns"></a>,
</li>
<li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove that paragraph?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because "Introduction" contains a description of sections, not subsections.
"Cross domain collaboration" and "System Integration" section are moved to subsections in Section 5
(5.10 and 5.11, respectively).

@mlagally mlagally merged commit c72e64f into w3c:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants