Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WOTMotion.en.vtt #166

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Update WOTMotion.en.vtt #166

merged 1 commit into from
Apr 27, 2021

Conversation

ashimura
Copy link
Collaborator

The starting time for the entry 10:
[[
10
00:00:29.500 --> 00:00:36.000
and are willing to broaden
their IoT knowledge.
]]
should be actually "00:00:33.500" instead of "00:00:29.500".

Maybe captions for other languages should be also fixed.

@ashimura ashimura added the bug Something isn't working label Apr 22, 2021
Copy link
Contributor

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@danielpeintner
Copy link
Contributor

Maybe captions for other languages should be also fixed.

Yes, if we all think the change is ok we should do so.

@mmccool
Copy link
Contributor

mmccool commented Apr 23, 2021

Agree, let's fix, but I ideally we can also find some way to test the new captions before deploying them.

@ashimura
Copy link
Collaborator Author

Right.

Actually, I myself checked the synchronization between the video and the captions using a simple index.html which includes a <video> tag :)

I'd suggest everybody also use that kind of index.html and have created PR172 for that purpose.

@sebastiankb
Copy link
Contributor

from today's marketing call:

  • ok to merge
  • we need to ask @dontcallmedom to update the caption file

@sebastiankb sebastiankb merged commit 0c8b2b0 into main Apr 27, 2021
@dontcallmedom
Copy link
Member

caption file updated both on YouTube & StreamFizz

@egekorkan egekorkan deleted the ashimura-patch-2 branch February 16, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants