Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the starting time of the entry 10 in WOTMotion.zh-Hans.vtt #169

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Fix the starting time of the entry 10 in WOTMotion.zh-Hans.vtt #169

merged 1 commit into from
Apr 27, 2021

Conversation

ashimura
Copy link
Collaborator

see also #166

@ashimura ashimura added the bug Something isn't working label Apr 23, 2021
@ashimura ashimura mentioned this pull request Apr 23, 2021
Merged
mmccool
mmccool approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@mmccool mmccool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the captions start before the video does does seem odd, so this seems reasonable. I assume it has been tested in a video player?

@ashimura
Copy link
Collaborator Author

Yes, I did test the synchronization between the video and the captions using a simple index.html with my Web browser on my PC :)

I'd suggest everybody check the synchronization locally before submitting a PR, so have created PR 172 for that purpose.

@sebastiankb
Copy link
Contributor

ok to merge, also see #166

@sebastiankb sebastiankb merged commit 2623a54 into main Apr 27, 2021
@egekorkan egekorkan deleted the ashimura-patch-4 branch February 16, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmccool mmccool mmccool approved these changes

@danielpeintner danielpeintner Awaiting requested review from danielpeintner

@sebastiankb sebastiankb Awaiting requested review from sebastiankb

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashimura @sebastiankb @mmccool