Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Testfest/Plugfest - informative assertion markup - generate manual.csv #295

Closed
wants to merge 8 commits into from

Conversation

mlagally
Copy link
Contributor

@mlagally mlagally commented Sep 26, 2022

This PR prepares the specification draft and provides the list of normative assertions that are to be tested and verified in the Testfest/Plugfest.

Changes:

  1. Modify the normative RFC2119 markup in informative sections in the document to be informative.
  2. Generate assertions.csv and manual.csv
  3. Minor script modifications

Preview | Diff

@mlagally mlagally changed the title generate manual.csv Prepare Testfest/Plugfest - informative assertion markup - generate manual.csv Sep 27, 2022
@egekorkan
Copy link
Contributor

I guess it is fine but profile testing should not be a copy paste of the TD testing in my opinion. Testing some TDs does not show any OOTBI

@@ -1 +1,82 @@
"ID","Status","Comment"
"Index","ID","Status","Comment","Assertion"
Copy link
Contributor

@sebastiankb sebastiankb Sep 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, this looks good, but we should also consider an interop test by two independent implementations since this is an important aspect of the profile. Maybe this should be considered in the manual assertions?

@benfrancis
Copy link
Member

benfrancis commented Sep 28, 2022

Modify the normative RFC2119 markup in informative sections in the document to be informative.

I personally think it's too early to decide which parts of the specification to make informative as a strategy for allowing the specification to proceed to CR. I don't think there's yet sufficient evidence that the HTTP Basic Profile is any better supported than the HTTP SSE Profile for example.

But as long as all of the assertions are included in test reports then I suppose we can revert these changes later if necessary.

@mlagally
Copy link
Contributor Author

Arch call on Oct. 19th.
Close without merging, this is superseeded by #296

@mlagally mlagally closed this Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants