-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Provide example in the new introduction section #334
base: main
Are you sure you want to change the base?
Conversation
<a href="#simple-profile-td-sample">Example 1</a> shows a <a>Thing Description</a> | ||
instance that follows the <a>HTTP Basic Profile</a> as described in this | ||
sepecification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest describing this as "a Thing Description of a Web Thing which follows the HTTP Basic Profile", since it's really the Web Thing that follows the profile, not just the Thing Description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sepecification -> specification
"@context": "https://www.w3.org/2022/wot/td/v1.1", | ||
"id": "urn:uuid:0804d572-cce8-422a-bb7c-4212fcd56f06", | ||
"profile": "https://www.w3.org/2022/wot/profile/http-basic/v1", | ||
"title": "MyHTTPBasicProfileLampThing", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Title is meant to be a human readable string, so I would suggest adding spaces in the text.
}, | ||
"security": "basic_sc", | ||
"properties": { | ||
"status": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Status is a bad name for a property. Any property could be described as being the Thing's status.
}</pre> | ||
</aside> | ||
<p> | ||
This <a>Thing Description</a> uses the <code>profile</code> term to signalize that the associated <a>Thing</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
signalize -> signal
</aside> | ||
<p> | ||
This <a>Thing Description</a> uses the <code>profile</code> term to signalize that the associated <a>Thing</a> | ||
supports the <a>HTTP Basic Profile</a>. As a security scheme, this example enforces authentication before access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"No matching definition" for "HTTP Basic Profile", need to add href="#http-basic-profile
.
@sebastiankb Can you please rebase and resolve the merge conflict? |
<this PR is wip; please do not merge>
This PR takes the introduction text from @benfrancis and extended it with an example section to give the reader an easy-to-understand example of what a profile-based TD looks like.
Preview | Diff