Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Provide example in the new introduction section #334

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sebastiankb
Copy link
Contributor

@sebastiankb sebastiankb commented Dec 7, 2022

<this PR is wip; please do not merge>

This PR takes the introduction text from @benfrancis and extended it with an example section to give the reader an easy-to-understand example of what a profile-based TD looks like.


Preview | Diff

Comment on lines +279 to +281
<a href="#simple-profile-td-sample">Example 1</a> shows a <a>Thing Description</a>
instance that follows the <a>HTTP Basic Profile</a> as described in this
sepecification.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest describing this as "a Thing Description of a Web Thing which follows the HTTP Basic Profile", since it's really the Web Thing that follows the profile, not just the Thing Description.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sepecification -> specification

"@context": "https://www.w3.org/2022/wot/td/v1.1",
"id": "urn:uuid:0804d572-cce8-422a-bb7c-4212fcd56f06",
"profile": "https://www.w3.org/2022/wot/profile/http-basic/v1",
"title": "MyHTTPBasicProfileLampThing",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title is meant to be a human readable string, so I would suggest adding spaces in the text.

},
"security": "basic_sc",
"properties": {
"status": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Status is a bad name for a property. Any property could be described as being the Thing's status.

}</pre>
</aside>
<p>
This <a>Thing Description</a> uses the <code>profile</code> term to signalize that the associated <a>Thing</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signalize -> signal

</aside>
<p>
This <a>Thing Description</a> uses the <code>profile</code> term to signalize that the associated <a>Thing</a>
supports the <a>HTTP Basic Profile</a>. As a security scheme, this example enforces authentication before access
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"No matching definition" for "HTTP Basic Profile", need to add href="#http-basic-profile.

@mlagally
Copy link
Contributor

@sebastiankb Can you please rebase and resolve the merge conflict?
Is this still WIP?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants