Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonical representation 2 #57

Closed
wants to merge 3 commits into from
Closed

Conversation

mlagally
Copy link
Contributor

@mlagally mlagally commented Dec 10, 2020

Chapter structure skeleton

targets to address issue #55


Preview | Diff

Base automatically changed from master to main March 5, 2021 13:57
@mmccool
Copy link
Contributor

mmccool commented Apr 29, 2021

Probably should retire this PR, since canonicalization is now in the TD spec, but I will review first to see if any content (eg use case discussion) should be moved over to the TD spec.

@mmccool
Copy link
Contributor

mmccool commented May 6, 2021

Should replace (if necessary) with a link to the Canonical TD definition in the TD spec. Note however that due to sorting a canonical TD may have to be loaded into memory before processing (we considered but rejected a feature to sort definitions so they appear before uses... it complicated the definition a lot).

@mmccool
Copy link
Contributor

mmccool commented May 6, 2021

Two points discussed in this PR which are not in the TD version:

  • Base URLs (not sure why this is an issue; I guess we should forbid people "expanding" all URLs. If a base URL is used in the input and relative URLs in forms, the same should be used by the output of a canonicalizer...)
  • Encrypted TDs (this is orthogonal to the issue of canonicalization, but is related to signing; of course a signed TD may not be encrypted, but a public-key-encrypted TD would allow validation that it was encrypted by the owner of the private key).

@mmccool
Copy link
Contributor

mmccool commented May 7, 2021

  • Regarding "base": We could forbid it in canonical form, forcing expression of all URLs in absolute form, but that seems overly draconian and makes chaining signed changes to the base inconvenient/impossible. However I realized not allowing changes to the base and the endpoint URLs was just a special case of an assertion I already had not allowing changes to how URLs are expressed. I made this explicit here: More fixes to canonicalization wot-thing-description#1129, please review.
  • Regarding encryption: I don't think this belongs under canonicalization, but rather under a discussion of signing, or possible under a discussion of object security for TDs in discovery. So I left this out of my version.

@mlagally
Copy link
Contributor Author

vF2F on 23.6.:
Canonical forms and signing are targeted for the TD.
This PR needs to be adapted to reflect the state in the TD.
Also some parts wrt. to canonical TDs should be removed.

@mlagally mlagally closed this Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants