-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create echonetExampleTD.td.jsonld #85
Conversation
"observable":false, | ||
"forms": [ | ||
{ | ||
"href": "/elapi/v1/devices/<deviceId>/properties/brightness", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<deviceId>
is not a URI variable, right? At first glace it might confuse people.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is one as far as I understood. This is a bit of a TM than a TD since it does not have the concrete endpoints. I would imagine that there will be something like abc123
replacing the <deviceId>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it than be something like
"/elapi/v1/devices/{{deviceId}}/properties/brightness"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are talking about a TM yes, here I just copied their URLs of the slide. Ideally there should be the concrete URI here.
Comments (some discussed in main call July 14 2021):
|
@mmccool : This example is used for an analysis of potential gaps and see if we can pragmatically create a binding without hitting any blockers. So far Ege did not hit a problem when he converted the example to a TD. |
I'm not sure what this example adds to the WoT Profile specification. It doesn't define or use a profile or even use the profile mechanism. Would it make more sense for this example to live in the Thing Description or Protocol Binding Templates repository as an example of a Thing Description which describes an ECHONET device? |
@matsu200722 |
…sonld I have fixed indentation, added comment unofficial contribution and adjusted to make it a TM
I will review the updated JSON. Please give me some time. |
@mlagally @egekorkan
It seems to me that the following definition is a more desirable one. The type of property "brightness" is "number" , not "object" in ECHONET Lite Web API Device Description.
|
@matsu200722 I think you are right that the example is a TD for a specific device and contains forms, so it should follow the ".td." pattern. I also agree that the representation of properties could be simplified to correspond to your example. @egekorkan , what do you think? |
Thank you @matsu200722 . I will answer your feedback:
|
@mlagally @egekorkan |
@matsu200722 sorry for the late reply. I understand your concerns and sadly do not have a very satisfying (neither for me nor you) answer.
|
@egekorkan Thank you for your reply. |
I have followed slide 18 onwards of https://raw.githubusercontent.com/w3c/wot/main/PRESENTATIONS/2021-03-online-f2f/2021-03-15-ECHONET-Lite-WebAPI-ECHONET-Consortium.pdf to create this to show how an Echonet TD can look like