-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve descriptions of apikey and psk security schemes #1031
Conversation
|
Marking as "ready for review" but "not ready for merging". Intend to discuss in Security call on Jan 18 |
@OliverPfaff notes that there is an IETF RFC, https://tools.ietf.org/html/rfc4949 for security terminology we should cite, but unfortunately it does not define either "API Key" (which is a "marketing" term...) but more surprisingly (since it is used in other RFCs like TLS-PSK) does not define "PSK" or "pre-shared key". |
Rendering error seems to have been fixed now but new text still not showing up, so I'm probably not making the edit in the right place... will try to fix in/for the TD call, in the meantime please do try to provide feedback on the proposed text. I plan to reword the last sentence in the PSK spec to make is sound less like an assertion (it really should be, but testing would be difficult, so...) |
This looks good and has the content that I would look for when I am seeing these terms for the first time |
From today's TD call:
|
I did look into the the "issue" and my local rendering does work just fine. I think the updated content is in index.html. |
|
Rendering fixed, changes discussed above implemented. Ready to merge. |
One thing I have realized is that the API Key says that it can be in a proprietary format. Thus, wouldn't we need a keyword called format (or similar) that can be used to convey this information. Otherwise, one would need documentation on that format via out-of-band-information. The string value can be left open or constrained to a set of values if such formats are explored. |
from today's TD call we will merge this PR. |
To resolve issue #998
Notes:
Preview | Diff