Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event consumer: Alternative 2 - event consumer affordance #1330

Closed
wants to merge 1 commit into from

Conversation

mlagally
Copy link
Contributor

@mlagally mlagally commented Dec 15, 2021

Event consumer affordance to enable describing a servient with an event listener notification interface in a TD.


Preview | Diff

@egekorkan
Copy link
Contributor

My review for both proposals: postpone to TD2.0 and avoid any kind of discussion that would imply more discussion time hence less time for making sure that the current specification is well specified.

Opinion in general:
Even though this is adding simply another affordance, the mechanism and the behavior behind is not well explained nor the use case is specified beforehand nor anything was tried out (I do not mean tested/validated, simply just tried out) in a plugfest. Even if this is possible and implementable, we did not consider any other approaches and we should simply not approach a standardization activity like TD this way which tries to make sure that we can describe Thing interfaces in a generic way and not specify the first way that comes to mind.

@relu91
Copy link
Member

relu91 commented Dec 20, 2021

I'm afraid that I agree with @egekorkan. Although the proposal seems interesting is something completely brand new. As far as I remember we did even properly discuss which are the modalities on how we can extend the current interaction model. For example, we had a hard time figuring out how to introduce new operation types for async actions (a new affordance type might help to settle a long-standing discussion also there - JobAffordance).

if this proposal is about to push notifications (? I think we need a use case description), I would say is a paradigm shift... the affordance that we defined so far describes what a producer can do and not what it expects that a consumer would do. I'm confident that we can work on it but it requires time...

@mlagally
Copy link
Contributor Author

As a fundamental WoT concept a Thing can be anything, event consumer, event producer, server, client, servient.
A TD should be able to describe these different kind of things, and I think the current interaction model already almost contains all what is needed.

I think the alternative 1 is more straight forward and pretty easy to implement, because it only requires to add another operation (notify) to define an event consumer.

@sebastiankb
Copy link
Contributor

I'm agree with @egekorkan and @relu91. This proposal is more related for a potential TD 2.0 discussion. As I already mentioned we have currently the fundamental WoT paradigm “property, action and event”. This PR would cause a new affordance with “property, action, event, and eventConsumer” that would not only impact the TD spec, but also the conceptional description in Architecture as well as the Discovery, Binding Documents, Security and Profile docs.

@mlagally
Copy link
Contributor Author

mlagally commented Dec 22, 2021

@sebastiankb Thanks very much for your comments.
I have provided an alternative proposal in #1329 which does not require a new affordance, but just adds a new operation. This will not have significant impact on the other normative documents, except for profile, where we need it for push events.
I have provided a sequence diagram and more explanations in issue #1323 and suggest to continue the discussion there, to avoid fragmented conversations in several places.

@sebastiankb
Copy link
Contributor

@mlagally thanks for your response. Then I would suggest that we focus on proposal #1329 in this charter period.

@sebastiankb sebastiankb added the Needs discussion more discussion is needed before getting to a solution label Feb 4, 2022
@egekorkan
Copy link
Contributor

TD Call 13.12:

@egekorkan egekorkan closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defer to TD 2.0 Needs discussion more discussion is needed before getting to a solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants