Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security extension example and namespaces #538

Merged
merged 6 commits into from
Mar 29, 2019

Conversation

mmccool
Copy link
Contributor

@mmccool mmccool commented Mar 29, 2019

NOTE: this is based on top of PR #537, so includes those edits as well.

This PR addresses Issue #501. It provides an example of how to use an extension to implement a new security scheme, using OAuth2 as an example.

Also addresses #345, #350, and #470.

NOTE: OAuth2 is important but is also likely to be removed from the specification due to lack of implementation experience. So if we do remove it, this example can remain and still be valid (although we might have to remove the immediately preceding example).

@mmccool
Copy link
Contributor Author

mmccool commented Mar 29, 2019

Originally I had an assertion defining a standard namespace for security schemes but decided to drop it and update the example to use an "example.org" URL. We probably SHOULD define a standard namespace for security schemes but we can publish that separately and put it into a W3C NOTE (maybe the WoT Security Best Practices note). I realized it was redundant for schemes actually in the spec. So this PR really only includes an example. In the end I decided to say nothing about the overlap of @type and scheme...

@mmccool
Copy link
Contributor Author

mmccool commented Mar 29, 2019

Extended to also take care of Issue #470.

@takuki
Copy link
Contributor

takuki commented Mar 29, 2019

Does this mean that some level of JSON-LD processing will be needed to understand security schemes?

@mmccool
Copy link
Contributor Author

mmccool commented Mar 29, 2019

Also addressed Issue #350.
Replying to Taki's comments: JSON-LD processing will not be required to understand built-in schemes. It will be needed to understand extensions, including extensions defining security schemes. Which is why it is still a good idea to have built-in schemes. I suppose an implementation could take a middle ground though and understand "well-known" security schemes. We could publish a bunch in a note...

@mmccool
Copy link
Contributor Author

mmccool commented Mar 29, 2019

Also fixed #345

@mmccool mmccool mentioned this pull request Mar 29, 2019
@mmccool
Copy link
Contributor Author

mmccool commented Mar 29, 2019

OK to merge, but we will have to clean up the definition of extensions, perhaps in another document. We will merge, @vcharpenay will define some issues, @mmccool will work on them and define a PR to discuss in the main call next week, and we can aim to merge any updates by the next TD call.

@mmccool mmccool merged commit 17c39cb into w3c:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants