-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table of contents clarifications #254
Conversation
…and additional issues found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I have made a change in 4.6.2:
- the property name is 'url' and not
href
- the link (ie, url) is not leading to the ToC but the resource containing it (just to be precise)
- the property name is 'url' and not
- I have (now...) a problem disallowing fragment id-s altogether: I am fine when we refer to resources within the WP (eg, reading order or resources) but I do not think we can restrict values in links (ie, extra links) which are largely URL-s that the authors do not really control. An example from W3C: the 'official' URL for the W3C copyright is
http://www.w3.org/Consortium/Legal/ipr-notice#Copyright
; this means adding a 'copyright' link as part oflinks
(which would be perfectly justified) could not be added if this restriction is in effect.
I know we are a bit back to square one, and I we should give some thoughts on how to handle that...
(see [my comments](#254 (review)))
@mattgarrish, on the second item (if you agree) I believe the cleanest approach is:
I do not want to make the change without your agreement, though. |
Funny, I had the same thought last night as I was falling asleep (thinking of wpub is better than counting sheep!). I was thinking that we make the fragment conditional in the PublicationLink definition, though, to avoid having to repeat it elsewhere. For example:
(Do we call that section "links" now, so we have to say "links in the links property"?) |
Such a solution seems fine to me. Links (and this is why this name is adequate) are not always complete resources.
-L
… but I do not think we can restrict values in links (ie, extra links) which are largely URL-s that the authors do not really control.
Funny, I had the same thought last night as I was falling asleep (thinking of wpub is better than counting sheep!).
I was thinking that we make the fragment conditional in the PublicationLink definition, though, to avoid having to repeat it elsewhere. For example:
A URL [[!url]]. The URL MAY contain a fragment identifier only when used with ???
(Do we call that section "links" now, so we have to say "links in the links property"?)
|
WP as sheep:-) There are some issues that may lead to other 'links' (e.g., links of images, stuff like that), where similar restrictions may apply. Also, we may end up using a schema.org object later to replace it (pending some issues to be discussed with DanBri & Co). All this to say that It may be more future safe to add that remark to the individual items rather than the overall definition of PublicationLink imho. |
+1 to what @iherman suggested: these restrictions apply to the collection ( |
It's just a painful approach as the links property is the lone anomaly. But I'm not going to get worked up over it. It might just also be good to make clear in the publicationlink definition that people should refer to each property definition for possible additional restrictions. |
@mattgarrish from a JSON-LD perspective, |
Big +1 to that. Will you do these changes? |
Yup, just getting the little one off and then will push a fix. |
I've pushed a change to spell out the restriction in each section. (I also tweaked the "Extra resources" section to use "Links", but will return to that later.) |
@mattgarrish this should be merged, as far as I am concerned... |
This PR addresses the concern I raised in #251 by removing the fragment identifier for table of contents, as recommended by @iherman.
In trying to rewrite the section, I also noticed that we were mixing a lot of toc construction requirements into the property definition, when all the property does is identify the resource containing the toc. To fix this, I've created a new subsection under "Creation" to detail how to make the table of contents, and rewritten the infoset to specify how to obtain the link.
Of note is that it disallows a fragment identifier on PublicationLinks, and also explicitly disallows a resource from being listed in both the resource list and default reading order, or listed two or more times within either of those lists.
Comments welcome.
Preview | Diff