Don't ignore matchId for json output #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't ignore matchId for json output This field is very important to be able to compare ongoing and passed matches
|
generally I'd change exposed json field |
|
We have our own id, so we ignore this field. It is only used in the db. If exposed I would like to call it „originalMatchId“ with an attribute (can not rename the field without touching the db, also it is more fitting). |
|
also the ongoing matches also use our internal id, do not know why that would help here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't ignore matchId for json output
This field is very important to be able to compare ongoing and passed matches