Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the parachains-related networking to the right place #651

Open
tomaka opened this issue Jun 7, 2023 · 6 comments
Open

Move the parachains-related networking to the right place #651

tomaka opened this issue Jun 7, 2023 · 6 comments
Assignees

Comments

@tomaka
Copy link
Collaborator

tomaka commented Jun 7, 2023

Why is https://spec.polkadot.network/chapter-anv#sect-anv-network-messages in a separate section, and not in "Networking"? They are networking protocols.

I know that the organization of the source code makes it look so, but parachains aren't a pluggable extensions to Polkadot. They are core Polkadot mechanisms.

@0xCaso
Copy link
Contributor

0xCaso commented Jun 12, 2023

Thanks @tomaka!

@tomaka
Copy link
Collaborator Author

tomaka commented Jun 12, 2023

It also needs a bit of reorganization. Just moving the sections doesn't really produce a result that makes sense.

@bhargavbh
Copy link
Contributor

Do you mean moving the networking chapter after AnV or reorganisation within the networking chapter? if it's the former, i would say it's fine for Spec to have forward referencing. We would not want to reorg the spec too often as we  received feedback against it. If it's the later, could you elaborate a bit more?

@bhargavbh bhargavbh reopened this Jun 12, 2023
@tomaka
Copy link
Collaborator Author

tomaka commented Jun 12, 2023

I mean reorganize the networking chapter. Don't you think it's very confusing? It is very clearly visible that each sub-section was written separately without any coherence by different authors who each had a partial understanding of the networking, and then glued together artificially.

For example the new section 4.8.8 is called "Notification Messages" and 4.8.9 "Request & response", but the whole chapter contains a list of notification and request-responses protocols.
The new section 4.8.8 starts with "The notification messages...". Which notification messages? The answer is: the notification messages that are mentioned earlier in the "Availability & Validity" section from which the section was copy-pasted.

@bhargavbh
Copy link
Contributor

bhargavbh commented Jun 12, 2023 via email

@0xCaso
Copy link
Contributor

0xCaso commented Jun 13, 2023

Moved the changes to the branch https://github.com/w3f/polkadot-spec/tree/issue-651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants