Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run action from prebuilt image #68

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

Hacksore
Copy link
Contributor

@Hacksore Hacksore commented Nov 8, 2020

@w9jds This should solve slow build times seen in #67 if we allow the image to be built and published to dockerhub.

The only thing that you'd need to do is stick in a DOCKER_PASSWORD secret to the repo.

@w9jds
Copy link
Owner

w9jds commented Nov 9, 2020

I agree with this, let me check something really quick, I will merge this once I get it all set up. Thank you for this.

@w9jds w9jds merged commit 0a5173f into w9jds:master Nov 9, 2020
@Hacksore Hacksore deleted the use-prebuilt-docker-image branch November 9, 2020 13:50
@Hacksore
Copy link
Contributor Author

Hacksore commented Nov 9, 2020

Some results I was able to get from my project, a good 40-second reduction 🥳.

Before:
image

After:
image

One other thing to consider is we could create another action to build/publish nightly so that the latest firebase-tools are present in the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants