Add union support to eg #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MozarellaMan
force-pushed
the
add_union_eg_implementation
branch
from
fc784db
to
f677909
Compare
|
First of all, thanks and congratulations for opening PR #1! 🎉 I'll have a look at the PR now and see if I can figure out what's going on here :) |
wabisabia
reviewed
Sep 29, 2022
Co-authored-by: Christian Dunn <bkkchris.dunn@outlook.com>
|
All looks well here! Merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! So I thought this would be pretty easy and straightfoward -- but I'm actually kinda stumped! There is a really strange compiler error when running the test for this new functionality. What do you think? It doesn't seem to be an issue with the proc macro. Compiler bug or maybe I'm missing something 😄