Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hero & Hertz] 'bitshares-pricefeed' referencing bitUSD | BTS_Tools referencing BTC:USD (bitUSD|BTC:USD) #46

Open
grctest opened this issue Jan 20, 2018 · 3 comments

Comments

@grctest
Copy link
Contributor

grctest commented Jan 20, 2018

I created a similar issue on xeroc's repo.

There's a difference in price BTS:USD reference between the two Bitshares price feed libraries. @xeroc's scripts reference bitUSD meanwhile bts_tools references BTS:BTC:USD price feeds. This is the potential source of price feed differences for Hertz: https://btsapi.grcnode.co.uk/home

What's the appropriate USD reference for Hero and Hertz? bitUSD:BTS and/or BTS:BTC:USD?

Cheers

@grctest
Copy link
Contributor Author

grctest commented Jan 22, 2018

Would it be OK to involve the python-bitshares library as a dependency for retrieving data from the Bitshares blockchain, or should I perform a GET request against the HUG REST API within the price feed script?

@grctest
Copy link
Contributor Author

grctest commented Jan 24, 2018

I believe that the large price feed difference between bts_tools and the other price feeds was down to a programming error solved: #50

The original question is however still valid - referencing bitUSD vs BTS:BTC:USD, one/the other or a mix of both?

@grctest
Copy link
Contributor Author

grctest commented Oct 15, 2019

BSIP 76 (bitshares/bsips#221) has now set fixed (fake) price feeds for bitUSD.

Since this price feed script uses bitUSD as the price feed reference it's now producing inaccurate Hertz price feeds.

Can an alternative to bitUSD be provided for Hertz to become accurate again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant