Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak on 32-bit architectures #30

Closed
danfe opened this issue Dec 25, 2021 · 5 comments · Fixed by #31
Closed

Unbreak on 32-bit architectures #30

danfe opened this issue Dec 25, 2021 · 5 comments · Fixed by #31

Comments

@danfe
Copy link

danfe commented Dec 25, 2021

The MakeTable() function in pkg/checksum/crc.go accepts poly int parameter (which is later being cast to uint), but called with 0xedb88320 argument which overflows it on 32 bits. Consider this trivial patch.

wader added a commit that referenced this issue Dec 25, 2021
Thanks Alexey Dokuchaev @danfe for report and fix.

Fixes #30
@wader
Copy link
Owner

wader commented Dec 25, 2021

Thanks! i'm also working on adding a 32-bit build and test run to the CI.

Also thanks for the FreeBSD port, should i also add some kind of install instructions for how to use it in the README?

@wader wader closed this as completed in #31 Dec 25, 2021
wader added a commit that referenced this issue Dec 25, 2021
Thanks Alexey Dokuchaev @danfe for report and fix.

Fixes #30
@danfe
Copy link
Author

danfe commented Dec 25, 2021

Also thanks for the FreeBSD port, should i also add some kind of install instructions for how to use it in the README?

Installation is pretty straightforward and as simple as pkg install fq, not sure if such trivialities are worth mentioning in the README. :-) There also no special usage considerations that I can think of.

@wader
Copy link
Owner

wader commented Dec 25, 2021

Ok 👍 maybe will just mention that there is a port at least. Will do some rework of the install/build section in the readme soon.

@danfe
Copy link
Author

danfe commented Dec 25, 2021

maybe will just mention that there is a port at least.

Hmm, yeah I guess that would be nice, thanks!

@wader
Copy link
Owner

wader commented Jan 4, 2022

#29 adds a 32-bit (386) CI build for linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants