Add librsvg #445
Merged
Add librsvg #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wader
force-pushed
the
librsvg-again
branch
5 times, most recently
from
316f678
to
6cdcc45
Compare
Turns out build with librsvg is a bit messy: librsvg needs cairo, pango and gio (via glib) cairo alpine package builds with x11 stuff glib alpine package only has shared libraries and builds with libmount etc and so on, so i think only sane solution is to build these on our own. This also currently use a bit ugly workaround (--allow-multiple-definition) to be able to link with more than one rust staticlib library. For some safety add a new checkdupsym script that checks for collisions, hopefully we can remove this in the future. Add some documentation about fonts. Fixes problem with git checkout commit not updating submodules Fixes race condition in checkelf
|
Closes #444 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out build with librsvg is a bit messy:
librsvg needs cairo, pango and gio (via glib)
cairo alpine package builds with x11 stuff
glib alpine package only has shared libraries and builds with libmount etc
and so on, so i think only sane solution is to build these on our own.
This also currently uses a bit ugly workaround (--allow-multiple-definition)
to be able to link with more than one rust staticlib library. I'm not sure how
bad this is, maybe it can hide other problems? it seems to be activly worked on.
Add some documentation about fonts.
Fixes problem with git checkout commit not updating submodules
Fixes race condition in checkelf