Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error generating part2 reports when using older meta files from Axivity AX3 devices in version 3.0-0 and 2.9-0 #951

Closed
2 tasks done
Maylor8 opened this issue Oct 24, 2023 · 4 comments

Comments

@Maylor8
Copy link

Maylor8 commented Oct 24, 2023

Describe the bug
Generating new part2 meta files and reports using older part1 meta files from an Axivity produces this error message:

Part 2
Busy processing ... see D:/Alex/output_data/meta/ms2.out for progress


Report part 2
1 2Error in names(x) <- value :
'names' attribute [36] must be the same length as the vector [35]
In addition: Warning messages:
1: package ‘GGIR’ was built under R version 4.2.3
2: In colnames(QCout)[newcols] <- newcolnames :
number of items to replace is not a multiple of replacement length```

This error occurs in versions 3.0-0 and 2.10-1 but not 2.9-0 and older. we are also running the same script on meta files from GENEActiv and ActiGraph processed at teh same time, but the only issue has been with Axivity meta files.
example cwa meta file.zip
It seems that Vincent has tried to prevent this previously here: 62d6de0

Here is one of the meta files

To Reproduce
Take the meta/basic files from older processed Axivity data, and re-run part 2 in versions 2.10-1 or 3.0 (example meta file attached)

  1. Sensor brand: 'Axivity AX3'
  2. Approximate recording duration 7 days
  3. Are you using a sleep diary to guide the sleep detection: NO
  4. Copy of R command used: 'attached'
  5. Have you tried processing your data based on GGIR's default argument values? Does the issue you report still appear? YES

Expected behavior
Part 2 to generate as normal, as per previous working in version 2.9.

Screenshots
If applicable, add screenshots to help explain your problem. Note that usually we are not only interested in see the error message in red, but all GGIR output to the console.

Desktop (please complete the following information):

  • OS: Windows 11: Version 10.0.22621 Build 22621
  • GGIR Version 3.0-0, but the issue also happens in 2.10-1, but not 2.9-0

Additional context
None

Before submitting

  • Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there? reproduced on my pc as well as @Alex-Row on a different pc using Windows 10
  • Have you tried this on the latest master branch from GitHub? Yes, using the latest branch the error still occurs.
    example cwa meta file.zip
@Maylor8
Copy link
Author

Maylor8 commented Oct 24, 2023

apologies - the meta files for the Axivity were generated using version 3.0-0, not an older version of GGIR.

@vincentvanhees
Copy link
Member

This may relate to the issue that PR 947 tries to fix: #947

Could you try their branch?
remotes::install_github("zcx980605/GGIR", ref = "fix_typo_in_g.report.part2")

@Maylor8
Copy link
Author

Maylor8 commented Oct 25, 2023

@vincentvanhees Thanks, using that version worked ok and results look as expected.

@vincentvanhees
Copy link
Member

Great, thanks for confirming. I will close this issue, feel free to re-open if the problem returns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants