-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
facilitate double backward slashes + add verbose + couple of other minor updates #755
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #755 +/- ##
=========================================
Coverage ? 74.25%
=========================================
Files ? 88
Lines ? 10815
Branches ? 0
=========================================
Hits ? 8031
Misses ? 2784
Partials ? 0
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hi @vincentvanhees, just did a minor commit to handle the verbose option in the report part 2 and report part 4 (messages were printed even if verbose = FALSE). The rest of the PR looks good to me! |
This PR addresses a couple of minor issues in preparation for the 2.9-0 release. Although, for now I have kept the version number at 2.8-7. In that way we can make 2.8-7 release this week and then leave a bit of time to test more extensively before the 2.9-0 release later this month.
Fixes #721 => Filepathes being stored were incorrect in RData file, now fixed, even though GGIR itself does not use them.
Fixes #570 => We now facilitate also double backward slash for file and folder paths
Fixes #704 => GGIR version is now better recognised for developers who have not installed GGIR.
Fixes #652 => Argument verbose added to ease turning off console messages.
Checklist before merging:
inst/NEWS.Rd
with a user-readable summary. Please, include references to relevant issues or PR discussions.DESCRIPTION
andCITATION.cff
files.