Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of absence in sustained inactivity bouts during first night #813

Merged
merged 4 commits into from
Jun 28, 2023

Conversation

vincentvanhees
Copy link
Member

@vincentvanhees vincentvanhees commented Jun 26, 2023

This small PR should address:

fixes #812
fixes #806

Checklist before merging:

  • Existing tests still work (check by running the test suite, e.g. from RStudio).
  • Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
  • Updated or expanded the documentation.
  • Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
  • Added your name to the contributors lists in the DESCRIPTION and CITATION.cff files.

@codecov-commenter
Copy link

Codecov Report

Merging #813 (3011cf5) into master (0aeaa63) will decrease coverage by 0.04%.
The diff coverage is 87.50%.

❗ Current head 3011cf5 differs from pull request most recent head 0e51643. Consider uploading reports for the commit 0e51643 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
- Coverage   74.02%   73.98%   -0.04%     
==========================================
  Files          90       90              
  Lines       11521    11523       +2     
==========================================
- Hits         8528     8525       -3     
- Misses       2993     2998       +5     
Impacted Files Coverage Δ
R/g.part4.R 74.96% <83.33%> (+0.03%) ⬆️
R/GGIR.R 69.43% <100.00%> (+0.11%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@jhmigueles jhmigueles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me. The issue Mikael is reporting in the google group is related with the formatting of their sleeplog. In g.loadlog line 11, their sleeplog is misclassified as basic sleeplog because their column names state "Date" instead of "date". We can suggest them to revise that, or we can make the column names identification case insensitive by adding ignore.case = TRUE to the grep functions in g.loadlog.

@vincentvanhees
Copy link
Member Author

or we can make the column names identification case insensitive by adding ignore.case = TRUE to the grep functions in g.loadlog.

Good idea, as I do not think we ever intended this to be case sensitive. I will add that now to this branch and then make the merge.

@vincentvanhees vincentvanhees merged commit cc659da into master Jun 28, 2023
@vincentvanhees vincentvanhees deleted the issue812_absence_sib_firstday branch June 30, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants