Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue812 sib first day loadlog #818

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Conversation

jhmigueles
Copy link
Collaborator

@jhmigueles jhmigueles commented Jun 29, 2023

Fixes #812 => minor addition to make the column identification for the advanced sleeplog case insensitive.

Checklist before merging:

  • Existing tests still work (check by running the test suite, e.g. from RStudio).
  • Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
  • Updated or expanded the documentation.
  • Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
  • Added your name to the contributors lists in the DESCRIPTION and CITATION.cff files.

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Merging #818 (cb04489) into master (949b175) will not change coverage.
The diff coverage is 100.00%.

❗ Current head cb04489 differs from pull request most recent head c623fac. Consider uploading reports for the commit c623fac to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #818   +/-   ##
=======================================
  Coverage   74.15%   74.15%           
=======================================
  Files          92       92           
  Lines       11665    11665           
=======================================
  Hits         8650     8650           
  Misses       3015     3015           
Impacted Files Coverage Δ
R/g.loadlog.R 88.00% <100.00%> (ø)

Copy link
Member

@vincentvanhees vincentvanhees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@vincentvanhees vincentvanhees merged commit 3f91a71 into master Jun 30, 2023
@vincentvanhees vincentvanhees deleted the issue812_sibFirstDay_loadlog branch June 30, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle absence of sustained inactivity bouts during first night
3 participants