Support running on preview versions of .NET #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we're determining the shared framework implementation paths, we parse the version number to a `System.Diagnostics.CodeAnalysis.Version` so we can choose the latest point release (so e.g. 5.0.10 comes after 5.0.9, which wouldn't be the case for normal string sorting). However, for preview versions of .NET, the version string has a trailing identifier, e.g. `6.0.0-preview.4.21253.7`, which causes `System.Diagnostics.CodeAnalysis.Version` to throw. Note, unit tests were failing when targeting `net6.0`; this fixes them all. fixes #8
Codecov Report
@@ Coverage Diff @@
## main #9 +/- ##
=======================================
+ Coverage 71.3% 71.4% +0.1%
=======================================
Files 20 20
Lines 1078 1082 +4
Branches 91 91
=======================================
+ Hits 769 773 +4
Misses 277 277
Partials 32 32
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we're determining the shared framework implementation paths, we parse the version number to a
System.Diagnostics.CodeAnalysis.Versionso we can choose the latest point release (so e.g. 5.0.10 comes after 5.0.9, which wouldn't be the case for normal string sorting). However, for preview versions of .NET, the version string has a trailing identifier, e.g.6.0.0-preview.4.21253.7, which causesSystem.Diagnostics.CodeAnalysis.Versionto throw.Note, unit tests were failing when targeting
net6.0; this fixes them all.fixes #8