Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion pane should not open when selection is active #126

Closed
kindermannhubert opened this issue Feb 25, 2022 · 0 comments · Fixed by #127
Closed

Completion pane should not open when selection is active #126

kindermannhubert opened this issue Feb 25, 2022 · 0 comments · Fixed by #127

Comments

@kindermannhubert
Copy link
Collaborator

kindermannhubert commented Feb 25, 2022 •
edited
Loading

Write apple. and select e. from left to right (from right to left it works correctly).
image
Trigger completion by Ctrl+Space. In Debug it fails on multiple asserts.

We intentionally do not support showing the completion list while selection is active.

I would move codePane.Selection is null check from CompletionPane.OnKeyDown directly to CompletionPane.Open method (it's called one more time in CompletionPane.OnKeyUp where the check is missing).
kindermannhubert added a commit to kindermannhubert/PrettyPrompt that referenced this issue Mar 6, 2022
@kindermannhubert
Fix of waf#126 (Completion pane should not open when selection is act…
f818544 
…ive).
@kindermannhubert kindermannhubert mentioned this issue Mar 6, 2022
Merged
kindermannhubert added a commit that referenced this issue Mar 6, 2022
@kindermannhubert
Merge pull request #127 from kindermannhubert/completion-list-fix
c3295c3 
Fix of #126 (Completion pane should not open when selection is active).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@kindermannhubert