Fix behavior of ParentalKeys and prefetch_related() supplied with a lookup queryset #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method must return a copy of the queryset for prefetch_one_level() to work correctly. Otherwise the result cache of the singular Prefetch lookup queryset is overridden and incorrect prefetched results are returned.
|
Thanks @juyrjola! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RelatedManager._apply_rel_filters()must return a copy of the queryset for Django's prefetch_one_level() to work correctly. Otherwise the result cache of the singular Prefetch lookup queryset is overridden and incorrect prefetched results are returned.I've included a test that should fail if this fix is not in place.