Add support for docker-compose. #221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntainer with volumes to make the database persistent, and for developers to make changes to the editor guide code and test them out on the running container.
… the frontend container to be able to run npm commands
| @@ -0,0 +1,98 @@ | |||
| # (Keep the version in sync with the node install below) | |||
There was a problem hiding this comment.
Question: What's the value in having a separate dockerfile? The main one ought to work just fine for this.
|
|
||
| docker-init: | ||
| docker exec -it guide_latest /bin/bash -c "make backend" | ||
| docker-compose exec web poetry install |
There was a problem hiding this comment.
Question: Why are dependencies being run like this? It happens during build time, which is probably fine.
Suggested change
| docker-compose exec web poetry install |
| dockerfile: Dockerfile.localdev | ||
| extra_hosts: | ||
| - 'host.docker.internal:host-gateway' | ||
| command: poetry run python manage.py runserver 0.0.0.0:${PORT:-8000} |
There was a problem hiding this comment.
Issue: If we always override the command here, why not just put it in the dockerfile?
| ports: | ||
| - '${PORT:-8000}:${PORT:-8000}' | ||
| environment: | ||
| SECRET_KEY: $SECRET_KEY |
There was a problem hiding this comment.
Why are we duplicating these to pass them through? I'd recommend either using dummy values, or having docker-compose read from a .env file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An iteration on some Makefile commands I added earlier. I realised that it was too hard to manage the container using only docker, it's much nicer to use docker-compose. This makes it easier to manage the container with volumes to make the database persistent, and for developers to make changes to the editor guide code and test them out on the running container.
I did have to make my own version of the Dockerfile but only because I couldn't override the
POETRY_INSTALL_ARGSsetting in the Dockerfile.