Add Permissions-Policy and Content-Security-Policy headers
#226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if "CSP_BASE_URI" in env: | ||
| CSP_BASE_URI = env.get("CSP_BASE_URI").split(",") | ||
| if "CSP_OBJECT_SRC" in env: | ||
| CSP_OBJECT_SRC = env.get("CSP_OBJECT_SRC").split(",") |
There was a problem hiding this comment.
Could you add documentation on how we’re configuring this for production? If possible, I’d be interested in tightening things down for this project as we don’t currently rely on any external resources on the site front-end, and maybe just Gravatar and releases.wagtail.org on the backend (?).
From a security standpoint the model where we give editor access to lots of people across all the different languages is a bit of a worst-case scenario.
RealOrangeOne
approved these changes
Nov 3, 2023
thibaudcolas
force-pushed
the
security-headers
branch
from
1bfa20d
to
bdc44b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #126.